Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-39306: Update SourceDetectionTasks to use excludeMaskPlanes EDGE by default. #266

Merged
merged 1 commit into from May 22, 2023
Merged

DM-39306: Update SourceDetectionTasks to use excludeMaskPlanes EDGE by default. #266

merged 1 commit into from May 22, 2023

Conversation

erykoff
Copy link
Contributor

@erykoff erykoff commented May 22, 2023

This PR moves the excludeMaskPlanes default from the SourceDetectionTask default to the tasks within ip_diffim which need this override.

isullivan
isullivan approved these changes May 22, 2023
View reviewed changes
Copy link
Contributor

@isullivan isullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be all the places the config is needed for now, thank you for catching them all.

@erykoff erykoff merged commit 41be43c into main May 22, 2023
1 check passed
@erykoff erykoff deleted the tickets/DM-39306 branch May 22, 2023 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isullivan isullivan isullivan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@erykoff @isullivan