DM-39976: Replace masked image pixels with median values before convolution #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isullivan
force-pushed
the
tickets/DM-39976
branch
from
c71d5ad
to
addaa0e
Compare
isullivan
force-pushed
the
tickets/DM-39976
branch
from
addaa0e
to
df7856c
Compare
Comment on lines
1038
to
1067
|
|
||
|
|
||
| def _interpolateImage(maskedImage, badMaskPlanes, fallbackValue=None): | ||
| """Replace masked image pixels with interpolated values. | ||
|
|
||
| Parameters | ||
| ---------- | ||
| maskedImage : `lsst.afw.image.MaskedImage` | ||
| Image on which to perform interpolation. | ||
| badMaskPlanes : `list` of `str` | ||
| List of mask planes to interpolate over. | ||
| fallbackValue : `float`, optional | ||
| Value to set when interpolation fails. | ||
| """ | ||
| image = maskedImage.image.array | ||
| badPixels = (maskedImage.mask.array & maskedImage.mask.getPlaneBitMask(badMaskPlanes)) > 0 | ||
| image[badPixels] = np.nan | ||
| if fallbackValue is None: | ||
| fallbackValue = np.nanmedian(image) | ||
| # For this initial implementation, skip the interpolation and just fill with | ||
| # the median value. | ||
| image[badPixels] = fallbackValue |
There was a problem hiding this comment.
This is good.
Fallback value could also be a local quantity? Probably for next change.
BrunoSanchez
approved these changes
Sep 12, 2023
isullivan
force-pushed
the
tickets/DM-39976
branch
from
df7856c
to
bf6eb76
Compare
|
I think we can discuss new tickets with more detailed analysis and improvements using actual interpolation during sprint planning. |
Only use with preconvolution and the Score image used for detection for now.
isullivan
force-pushed
the
tickets/DM-39976
branch
from
bf6eb76
to
2e5f4c3
Compare
|
I have reviewed the changes and the notebooks with the results of run comparisons. |
| @@ -372,6 +372,8 @@ def run(self, template, science, sources, finalizedPsfApCorrCatalog=None, | |||
| ) | |||
| self.log.info("Science PSF FWHM: %f pixels", sciencePsfSize) | |||
| self.log.info("Template PSF FWHM: %f pixels", templatePsfSize) | |||
| self.metadata.add("sciencePsfSize", sciencePsfSize) | |||
| self.metadata.add("templatePsfSize", templatePsfSize) | |||
There was a problem hiding this comment.
Fine by me, adding metadata is not enough for us to do another ticket.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only use with preconvolution and the Score image used for detection for now.