DM-15180: Add coordinate error fields to diaSrc #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isullivan
approved these changes
Sep 7, 2023
isullivan
approved these changes
Sep 8, 2023
There was a problem hiding this comment.
I believe you will also need to add lsst.afw.table.updateSourceCoords(difference.getWcs(), diaSources) after forced source measurement in DetectAndMeasureTask.processResults
Edit: maybe this is not necessary after all. There are other reasons the raErr and decErr are not showing up in the diaSource catalogs, and fixing that should be a ticket for someone probably in AP.
cmsaunders
force-pushed
the
tickets/DM-15180
branch
from
8630478
to
9415af6
Compare
cmsaunders
force-pushed
the
tickets/DM-15180
branch
from
9415af6
to
9a80524
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.