DM-32769: Implement streak detection and masking in single frame processing #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrawls
force-pushed
the
tickets/DM-32769
branch
from
53c39d8
to
eef69e8
Compare
mrawls
force-pushed
the
tickets/DM-32769
branch
2 times, most recently
from
f854411
to
5b11695
Compare
mrawls
changed the title
bsmartradio
approved these changes
Oct 26, 2023
python/lsst/ip/diffim/utils.py
Outdated
| @@ -1265,6 +1265,7 @@ def detectTestSources(exposure): | |||
| sigma=None, # The appropriate sigma is calculated from the PSF | |||
| doSmooth=True | |||
| ) | |||
| exposure.mask.addMaskPlane("STREAK") # Cannot run maskStreaksTask here, as it's in pipe_tasks | |||
There was a problem hiding this comment.
Just curious why we need to know that we can't run maskStreakTask at this location. Is that something we might want to do?
There was a problem hiding this comment.
I see in another PR you do self.exposure.mask.addMaskPlane("STREAK") # add empty streak mask plane in lieu of maskStreaksTask as the explanation instead. Maybe swap to that?
There was a problem hiding this comment.
Good call for consistency's sake, will update. (I originally called the task here, and realized that wouldn't work since pipe_tasks explicitly depends on ip_diffim being setup, and the reverse cannot be true.)
Also add the STREAK mask plane to the test exposure util. Without this, the pixelFlags plugin will fail, and we cannot run maskStreaksTask directly since it's in pipe_tasks.
mrawls
force-pushed
the
tickets/DM-32769
branch
from
5b11695
to
0a2ee26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR propagates streak mask info through
detectAndMeasureTask.