DM-41180: Make matching kernel fitting more robust #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any candidates that would raise an error will be rejected, so we can safely continue without them.
isullivan
force-pushed
the
tickets/DM-41180
branch
from
6590162
to
1ba2af3
Compare
yalsayyad
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore errors during the early stage of rejecting kernel candidates, since any candidates with errors will be rejected and we can proceed with the remaining good sources.
Fix the docstring for
nStarPerCellto better reflect its function, update its default value, and remove the check so that removing the limit on the number of kernel candidates per cell is possible.