Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-41955: Remove unphysical diaSources from the output of detectAndMeasure #287

Merged
merged 6 commits into from
Jan 4, 2024
Merged

DM-41955: Remove unphysical diaSources from the output of detectAndMeasure #287

merged 6 commits into from
Jan 4, 2024

Commits on Dec 15, 2023

  1. Remove unphysical diaSources from the output of detectAndMeasure

    @isullivan
    isullivan committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    dc7c7af View commit details
    Browse the repository at this point in the history

  2. Respond to review

    @isullivan
    isullivan committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    2e33967 View commit details
    Browse the repository at this point in the history

  3. Remove diaSources with NaN centroids 

    Downstream code will break in multiple places if there is a single diaSource with a NaN value from .getCentroid()
    @isullivan
    isullivan committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    e60df45 View commit details
    Browse the repository at this point in the history

Commits on Dec 23, 2023

  1. Clean up variable and method names

    @isullivan
    isullivan committed Dec 23, 2023
    Configuration menu
    Copy the full SHA
    2d89abf View commit details
    Browse the repository at this point in the history

  2. Add consistency check of schema and config in Task init

    @isullivan
    isullivan committed Dec 23, 2023
    Configuration menu
    Copy the full SHA
    7ab489c View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2024

  1. Remove extra check for NaN centroids. 

    With DM-42313 merged, these should be caught by `base_PixelFlags_flag_offimage`
    @isullivan
    isullivan committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    3c9f4bd View commit details
    Browse the repository at this point in the history