Tickets/dm 7320 #29
Merged
Tickets/dm 7320 #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 27 commits
August 22, 2016 12:12
|
Please do a quick pass and remove all the |
|
testDipole still has a bunch of assertTrue that can be cleaned up. Also, please move the np.random.seed into the class setUp. |
|
Please also remove empty setUp and tearDown (those that just have |
|
There's a bunch of bad handling of dataDir that should be turned into |
|
Makes sense, I'll make the indicated changes and update the JIRA ticket. |
|
Proper skipping is an important part of pytest upgrades. It really helps a lot to see the skips explicitly in the results rather than a test module just exiting early. |
added 7 commits
August 23, 2016 16:12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.