DM-39466: Added flagging of sources near the INJECTED and INJECTED_TEMPLATE mask plane #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrunoSanchez
force-pushed
the
tickets/DM-39466
branch
from
e0888b4
to
b28c2fc
Compare
isullivan
changed the title
BrunoSanchez
commented
Jan 16, 2024
BrunoSanchez
commented
Jan 16, 2024
BrunoSanchez
force-pushed
the
tickets/DM-39466
branch
3 times, most recently
from
3724b0a
to
10d485b
Compare
isullivan
approved these changes
Jan 17, 2024
There was a problem hiding this comment.
The code changes look fine, and my local tests with ap_verify pass. Please add a new unit test to check that detectAndMeasure correctly flags sources with footprints including pixels with the INJECTED or INJECTED_TEMPLATE mask set. A simple Jenkins re-run (without ci_hsc or ci_imsim) should be sufficient if you just add a test.
BrunoSanchez
force-pushed
the
tickets/DM-39466
branch
2 times, most recently
from
43b4832
to
fcb4529
Compare
isullivan
approved these changes
Jan 23, 2024
BrunoSanchez
force-pushed
the
tickets/DM-39466
branch
from
fcb4529
to
a770d1e
Compare
|
I have applied the changes requested for the test. This improves significantly the quality of this unit test. Thanks very much |
Added requested test. Modified a test from subtract and migrated it to detectandmeasure
BrunoSanchez
force-pushed
the
tickets/DM-39466
branch
from
a770d1e
to
0f3fc58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.