DM-42814: Cleanup makeKernel candidateList handling #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parejkoj
force-pushed
the
tickets/DM-42814
branch
from
69c20a2
to
8456e2a
Compare
BrunoSanchez
approved these changes
Feb 15, 2024
| @@ -38,6 +40,8 @@ | |||
| from . import diffimLib | |||
|
|
|||
|
|
|||
| @deprecated(reason="This config class is no longer used. Will be removed after v27.", | |||
| version="v27.0", category=FutureWarning) | |||
There was a problem hiding this comment.
Is this showing up in the docs and also during runtime?
There was a problem hiding this comment.
This will appear any time someone instantiates this class, including in the logs of pipelines that use it.
But this reminded me that I need to also deprecate the ConfigField that uses it in PsfMatchConfig.
| @@ -8,7 +8,7 @@ | |||
| * | |||
| * @ingroup ip_diffim | |||
| */ | |||
|
|
|||
| #include <stdexcept> | |||
There was a problem hiding this comment.
Is this the LSST exception module?
There was a problem hiding this comment.
Nope, <> includes are from the standard library. It was necessary for std::logic_error.
There was a problem hiding this comment.
It all looks cleaner. Thanks
|
Looking at this again, I think I will have to file an RFC, even though it seems silly: any deprecations do officially need one. |
parejkoj
force-pushed
the
tickets/DM-42814
branch
from
8456e2a
to
630a14b
Compare
Remove sourceToFootprintList and replace with modern afw Exposure methods: * makeCandidateList now just takes a SourceCatalog and checks that it is useable. * _buildCellSet now takes a SourceCatalog and makes candidates from it directly. Cleanup docstrings to match.
An exception here gets logged above anyway, so this is just clutter.
With the refactor of makeCandidateList, the FindSetBits code is no longer necessary (afw Mask already has everything we need) and KernelCandidateDetection is ancient and unused. Since that C++ is the only thing that used it, deprecate DetectionConfig, too.
No need to output such sub-pixel precision.
Move makePoissonNoiseImage from diffimTools.py to the one test that still uses it.
parejkoj
force-pushed
the
tickets/DM-42814
branch
from
630a14b
to
6f13da2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.