DM-42774: Rename difference image mask planes to include _TEMPLATE if they are set from the template #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrunoSanchez
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
The way github broke apart the line changes is wonky, but I can see how this works and it looks good.
| @@ -1018,7 +1018,7 @@ def computeAveragePsf(exposure: afwImage.Exposure, | |||
| return psfImage | |||
|
|
|||
|
|
|||
| def detectTestSources(exposure): | |||
| def detectTestSources(exposure, addMaskPlanes=None): | |||
There was a problem hiding this comment.
Please add the docs for this new optional parameter.
There was a problem hiding this comment.
Just the docstring change. It looks good.
tests/test_detectAndMeasure.py
Outdated
tests/test_subtractTask.py
Outdated
isullivan
force-pushed
the
tickets/DM-42774
branch
from
6dbd57d
to
bb107ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.