Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-40507: Cleanup DipoleFitTask #305

Merged
merged 8 commits into from
Mar 28, 2024
Merged

DM-40507: Cleanup DipoleFitTask #305

merged 8 commits into from
Mar 28, 2024

Commits on Mar 22, 2024

  1. Cleanup table key creation

    The loops made it hard to find where these keys were created, and there
    are helpers to create flux and centroid keys with their associated
    uncertainties automatically.
    Using NO_UNCERTAINTY for centroids, to make it explicit that we don't
    have uncertainties for these values right now.
    parejkoj committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    c2fea4a View commit details
    Browse the repository at this point in the history
  2. Cleanup docs/whitespace

    parejkoj committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    90e8ed3 View commit details
    Browse the repository at this point in the history
  3. Remove unnecessary plugins

    * Naive* are purely examples and shouldn't be used in production
    * Peak* are unnecessary with Psf and Dipole models and mostly for
    testing purposes
    * PsfDipoleFlux is slower than PsfDipoleFit (this task).
    * PsfDipoleFit provides a dipole classification.
    parejkoj committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    6fddec3 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c762f6a View commit details
    Browse the repository at this point in the history
  5. Use the default plugins, plus PsfDipoleFlux as a check

    PsfDipoleFlux is the older, slower algorithm, but it makes a useful
    check on the new PsfDipoleFit.
    parejkoj committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    d7bf17a View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2024

  1. Refactor dipoleFitTask to give better centroids

    * Enforce plugin order, so that DipoleFit can fall back on SdssCentroid
    for non-dipoles.
    * DipoleFitPlugin can run at "centroid" order, because it simultaneously fits
    centroids and fluxes.
    * Switch centroid slot after SdssCentroid, so that the "best" centroid
    comes from DipoleFit (even if it's just copied over).
    * Switch dipole centroid field names to better match centroid slot
    convention (foo_x/foo_y, for plugin foo).
    * Rename DipoleFitTask default name to match Task name convention.
    
    Cleanup tests to pass with the better centroids:
    * Loosen flux tolerance.
    * Remove test of "unphysical" sources that relied on bad centroiding
    pushing the sky sources off the image.
    * Remove tests that relied on old centroider behavior when measuring
    on unmerged footprints.
    
    Refactor non-dipole "error" handling:
    * No need to flag sources that were not fit as failures, they're already
    marked as not dipoles.
    * Handle "too large" footprints as failures separately from other non-
    dipole sources.
    * Remove redundant flag setting: some flags either default to False, or were
    set just above.
    parejkoj committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    11daecc View commit details
    Browse the repository at this point in the history
  2. Fix incorrect data type

    parejkoj committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    759ecd4 View commit details
    Browse the repository at this point in the history
  3. Fix debug logging and display2dArray

    We want the debug logs to appear if the loglevel is DEBUG.
    Plot display was broken because `show()` never got called!
    parejkoj committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    5a0dcae View commit details
    Browse the repository at this point in the history