-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-40507: Cleanup DipoleFitTask #305
Merged
Merged
Commits on Mar 22, 2024
-
The loops made it hard to find where these keys were created, and there are helpers to create flux and centroid keys with their associated uncertainties automatically. Using NO_UNCERTAINTY for centroids, to make it explicit that we don't have uncertainties for these values right now.
Configuration menu - View commit details
-
Copy full SHA for c2fea4a - Browse repository at this point
Copy the full SHA c2fea4aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 90e8ed3 - Browse repository at this point
Copy the full SHA 90e8ed3View commit details -
* Naive* are purely examples and shouldn't be used in production * Peak* are unnecessary with Psf and Dipole models and mostly for testing purposes * PsfDipoleFlux is slower than PsfDipoleFit (this task). * PsfDipoleFit provides a dipole classification.
Configuration menu - View commit details
-
Copy full SHA for 6fddec3 - Browse repository at this point
Copy the full SHA 6fddec3View commit details -
Configuration menu - View commit details
-
Copy full SHA for c762f6a - Browse repository at this point
Copy the full SHA c762f6aView commit details -
Use the default plugins, plus PsfDipoleFlux as a check
PsfDipoleFlux is the older, slower algorithm, but it makes a useful check on the new PsfDipoleFit.
Configuration menu - View commit details
-
Copy full SHA for d7bf17a - Browse repository at this point
Copy the full SHA d7bf17aView commit details
Commits on Mar 28, 2024
-
Refactor dipoleFitTask to give better centroids
* Enforce plugin order, so that DipoleFit can fall back on SdssCentroid for non-dipoles. * DipoleFitPlugin can run at "centroid" order, because it simultaneously fits centroids and fluxes. * Switch centroid slot after SdssCentroid, so that the "best" centroid comes from DipoleFit (even if it's just copied over). * Switch dipole centroid field names to better match centroid slot convention (foo_x/foo_y, for plugin foo). * Rename DipoleFitTask default name to match Task name convention. Cleanup tests to pass with the better centroids: * Loosen flux tolerance. * Remove test of "unphysical" sources that relied on bad centroiding pushing the sky sources off the image. * Remove tests that relied on old centroider behavior when measuring on unmerged footprints. Refactor non-dipole "error" handling: * No need to flag sources that were not fit as failures, they're already marked as not dipoles. * Handle "too large" footprints as failures separately from other non- dipole sources. * Remove redundant flag setting: some flags either default to False, or were set just above.
Configuration menu - View commit details
-
Copy full SHA for 11daecc - Browse repository at this point
Copy the full SHA 11daeccView commit details -
Configuration menu - View commit details
-
Copy full SHA for 759ecd4 - Browse repository at this point
Copy the full SHA 759ecd4View commit details -
Fix debug logging and display2dArray
We want the debug logs to appear if the loglevel is DEBUG. Plot display was broken because `show()` never got called!
Configuration menu - View commit details
-
Copy full SHA for 5a0dcae - Browse repository at this point
Copy the full SHA 5a0dcaeView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.