DM-43404: Create diffim QA metrics #306
Conversation
| """Add image QA metrics to the Task metadata. | ||
|
|
||
| Parameters | ||
| ---------- | ||
| difference : `lsst.afw.image.Exposure` | ||
| The target image to calculate metrics for. | ||
| diaSources : TYPE |
There was a problem hiding this comment.
Docstrings need updates in this section
| ), | ||
| ) | ||
| metricSources = pexConfig.ConfigurableField( | ||
| target=SkyObjectsTask, |
There was a problem hiding this comment.
I wonder if using sky objects as our probe will cause us to underestimate the mask fractions? But as we discussed it's a reasonable place to start.
| dipoleSources = selectSources[selectSources["ip_diffim_DipoleFit_flag_classification"]] | ||
| dipoleDensity = len(dipoleSources)/area | ||
| if dipoleSources: | ||
| meanDipoleOrientation = _angleMean(dipoleSources["ip_diffim_DipoleFit_orientation"]) |
There was a problem hiding this comment.
The docstring above said this was relative to the parallactic angle--I don't see that computation here, am I missing something?
There was a problem hiding this comment.
I originally thought it should be relative to parallactic angle, but then decided to simplify the calculation. I'll update the docstring.
| @@ -653,3 +821,13 @@ def run(self, science, matchedTemplate, difference, scoreExposure, | |||
|
|
|||
| return self.processResults(science, matchedTemplate, difference, sources, idFactory, | |||
| positiveFootprints=positives, negativeFootprints=negatives) | |||
|
|
|||
|
|
|||
| def _angleMean(angles): | |||
There was a problem hiding this comment.
a test of this function would help confirm we got the math right....
| @@ -247,6 +281,62 @@ def __init__(self, **kwargs): | |||
| for flag in self.config.badSourceFlags: | |||
| if flag not in self.schema: | |||
| raise pipeBase.InvalidQuantumError("Field %s not in schema" % flag) | |||
|
|
|||
| if self.config.doWriteMetrics: | |||
There was a problem hiding this comment.
As I said on the analysis_tools PR, I'm worried about calling these "metrics" as well when they are stored and handled quite differently from both lsst.verify.Metrics and analysis_tools metrics.
There was a problem hiding this comment.
Changed to spatiallySampledMetrics
isullivan
force-pushed
the
tickets/DM-43404
branch
from
320130e
to
912b9dc
Compare
isullivan
force-pushed
the
tickets/DM-43404
branch
from
912b9dc
to
fa2b451
Compare
No description provided.