Fix NaiveDipoleCentroid logic #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -102,10 +107,16 @@ def setDefaults(self): | |||
| "base_PixelFlags", | |||
| "base_SkyCoord", | |||
| "base_PsfFlux", | |||
| "base_GaussianCentroid", | |||
| #"base_GaussianFlux", | |||
There was a problem hiding this comment.
This should be removed if it's not required.
There was a problem hiding this comment.
base_GaussianFlux was commented out because it leads to a schema set-up failure:
Alias for 'slot_Shape_flag' must be defined before initializing 'base_GaussianFlux' plugin. {0}
lsst::pex::exceptions::LogicError: 'Alias for 'slot_Shape_flag' must be defined before initializing 'base_GaussianFlux' plugin.'
I'll remove this line now, but I've filed a ticket (DM-7458), as I would like to add base_GaussianFlux to the default list of plugins.
There was a problem hiding this comment.
To run base_GaussianFlux, you'll need to run a shape algorithm (e.g. base_SdssShape), and set the shape slot to point to it (...config.measurement.slots.shape = 'base_SdssShape').
There was a problem hiding this comment.
Thanks, @TallJimbo -- this should be an easy fix.
Only fit dipoles to footprints with a pos. and neg. peak Remove debug statements Add other default plugins
djreiss
force-pushed
the
tickets/DM-7376
branch
from
e1a4096
to
24a03cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only fit dipoles to footprints with a pos. and neg. peak
remove debug statements; add other default plugins