Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-43848: Rewrite the spatially sampled metrics into a standalone pipelineTask. #312

Merged
merged 1 commit into from Apr 17, 2024
Merged

DM-43848: Rewrite the spatially sampled metrics into a standalone pipelineTask. #312

merged 1 commit into from Apr 17, 2024

Conversation

isullivan
Copy link
Contributor

No description provided.

@isullivan isullivan force-pushed the tickets/DM-43848 branch 2 times, most recently from 5b23efc to 5107f88 Compare April 17, 2024 00:39
BrunoSanchez
BrunoSanchez approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@BrunoSanchez BrunoSanchez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve the changes. Maybe double check the duplicated code in utils.py (w.r.t. DM-43641)

python/lsst/ip/diffim/utils.py Outdated Show resolved Hide resolved
@BrunoSanchez BrunoSanchez merged commit 6594611 into main Apr 17, 2024
2 checks passed
@BrunoSanchez BrunoSanchez deleted the tickets/DM-43848 branch April 17, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrunoSanchez BrunoSanchez BrunoSanchez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@isullivan @BrunoSanchez