DM-8002: Separate display logic from algorithm logic. #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsinfang
commented
Oct 17, 2016
| @@ -201,43 +201,56 @@ def selectStars(self, exposure, sourceCat, matches=None): | |||
| # | |||
| starCat = SourceCatalog(sourceCat.schema) | |||
|
|
|||
| if display: | |||
There was a problem hiding this comment.
From below it looks to me that if display and displayExposure: would be enough?
There was a problem hiding this comment.
Correct. Will adjust accordingly.
This split in logic is necessary to guard the call to ds9.Buffering() with an `if display` statement, but it's also cleaner.
TallJimbo
force-pushed
the
tickets/DM-8002
branch
from
645340a
to
1eb8439
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This split in logic is necessary to guard the call
to ds9.Buffering() with an
if displaystatement,but it's also cleaner.