DM-7000: Convert tracing to use lsst.log and remove pex.logging #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 9, 2016 18:20
Replace tracing under the component "lsst.ip.diffim" using lsst.log at DEBUG level, with the spcific component in its logger name and prefixed with TRACE<n>. Generally, <n> is 1 lower than the original Trace verbosity in pex.logging; i.e. pex.logging Trace at 1-6 are converted to TRACE0, TRACE1, TRACE2, TRACE3, TRACE4, and TRACE5. For example, "lsst.ip.diffim.comp" with pex.logging Trace3 is replaced by "TRACE2.ip.diffim.comp". Except - the logger "lsst.ip.diffim.KernelCandidateDetection" where Trace 14678 were used: converted to 12345 - the loggers in KernelSolution.cc where Trace 4567 were used: converted to 2345 - lsst.ip.diffim.ImageStatistics where Trace 67 were used: converted to TRACE4 and TRACE5 Also replace the level control placeholders in tests.
These loggers use no more than one level in tracing. Convert them into debug logging with lsst.log.
and remove pex_logging form ups table.
djreiss
reviewed
Nov 21, 2016
|
Most of the examples do not run, but Yes, the outputs are similar with the minor format differences. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.