DM-8467: Wrap lsst_distrib with pybind11 #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pschella
force-pushed
the
tickets/DM-8467
branch
2 times, most recently
from
f17ec8a
to
ec068e4
Compare
TallJimbo
force-pushed
the
tickets/DM-8467
branch
from
ec068e4
to
06a92e4
Compare
Eliminate all use of shared pointers to Eigen matrices and vectors, especially as arguments and return values. The impetus was that pybind11 did not wrap the return value from the following properly (it build but could not turn the result into a Python object, and the error message made it look like the result was an Eigen::MatrixXd instead of a shared pointer to the same): ``` std::shared_ptr<Eigen::MatrixXd> makeRegularizationMatrix ```
pschella
force-pushed
the
tickets/DM-8467
branch
from
06a92e4
to
6ef0d75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.