DM-9190: Cleanup pybind11 remaining code #51
Conversation
pschella
force-pushed
the
tickets/DM-9190
branch
2 times, most recently
from
ecf2c15
to
687cee9
Compare
| PYBIND11_PLUGIN(_kernelCandidateDetection) { | ||
| py::module mod("_kernelCandidateDetection", "Python wrapper for KernelCandidateDetection.h"); | ||
| PYBIND11_PLUGIN(kernelCandidateDetection) { | ||
| py::module::import("lsst.pex.policy"); |
There was a problem hiding this comment.
I'm pretty sure this code also needs lsst.afw.image and lsst.afw.detection
| py::module mod("_kernelSolution", "Python wrapper for KernelSolution.h"); | ||
| PYBIND11_PLUGIN(kernelSolution) { | ||
| py::module::import("lsst.afw.math"); | ||
| py::module::import("lsst.pex.policy"); |
There was a problem hiding this comment.
Also need lsst.afw.geom and lsst.afw.image
| @@ -136,7 +138,10 @@ void declarePsfDipoleFlux(py::module &mod) { | |||
| } // namespace lsst::ip::diffim::<anonymous> | |||
|
|
|||
| PYBIND11_PLUGIN(_dipoleAlgorithms) { | |||
| py::module mod("_dipoleAlgorithms", "Python wrapper for DipoleAlgorithms.h"); | |||
| py::module::import("lsst.afw.table"); | |||
| py::module::import("lsst.meas.base"); | |||
There was a problem hiding this comment.
Is lsst.pex.config needed for the control fields?
| from .kernelCandidate import * | ||
| from .kernelCandidateDetection import * | ||
| from .kernelSolution import * | ||
|
|
There was a problem hiding this comment.
This is the only package of the set, so far, that has retained its xLib.py file. Is this intentional?
There was a problem hiding this comment.
Yes it was. This is difficult to remove and expected to be restored in DM-9786.
Thus leave it in for now until a decision has been made on that ticket.
| PYBIND11_PLUGIN(_kernelSumVisitor) { | ||
| py::module mod("_kernelSumVisitor", "Python wrapper for KernelSumVisitor.h"); | ||
| PYBIND11_PLUGIN(kernelSumVisitor) { | ||
| py::module::import("lsst.afw.math"); |
There was a problem hiding this comment.
I believe this also needs lsst.pex.policy (used by makeKernelSumVisitor).
python/lsst/ip/diffim/basisLists.cc
Outdated
| PYBIND11_PLUGIN(_basisLists) { | ||
| py::module mod("_basisLists", "Python wrapper for BasisLists.h"); | ||
| PYBIND11_PLUGIN(basisLists) { | ||
| py::module mod("basisLists"); |
There was a problem hiding this comment.
I'm pretty sure this needs to import lsst.afw.math and lsst.pex.policy
Unlike other cleanup I left in the diffimLib module. This is difficult to remove and expected to be restored in DM-9786. Thus leave it in for now until a decision has been made on that ticket.
pschella
force-pushed
the
tickets/DM-9190
branch
from
687cee9
to
42c1cf6
Compare
No description provided.