ModelPsfMatchTask: Set output exposure PSF to model PSF used #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurenam
reviewed
Mar 29, 2017
| @@ -300,6 +300,7 @@ def run(self, exposure, referencePsfModel, kernelSum=1.0): | |||
| psfMatchedExposure = afwImage.ExposureF(exposure.getBBox(), exposure.getWcs()) | |||
| psfMatchedExposure.setFilter(exposure.getFilter()) | |||
| psfMatchedExposure.setCalib(exposure.getCalib()) | |||
| psfMatchedExposure.setPsf(referencePsfModel) | |||
There was a problem hiding this comment.
I don't pretend to have looked at the downstream code & potential consequences, so I'll just ask and accept your answer to the question: does the refererecePsfModel still need to be returned as a separate component of the Struct given that it is now explicitly attached to the returned psfMatchedExposure?
There was a problem hiding this comment.
It doesn't still need to be there. Because it has only been there for 4 months, it is extremely unlikely that anyone's non-stack scripts depend on it now, so I'm comfortable making the interface change of removing it.
PaulPrice
approved these changes
Mar 30, 2017
Remove referenceModelPsf from returned Struct, because it is now accessible from the psfMatchedExposure.
yalsayyad
force-pushed
the
tickets/DM-9564
branch
from
9d0ed71
to
62a3b6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.