tickets/DM-3213 #6
Conversation
| try: | ||
| kernelCandidate = kernelCandidate.getSource() | ||
| except: | ||
| raise RuntimeError, ("Candiate not of type afwTable.SourceRecord") |
There was a problem hiding this comment.
The error message is incomplete, since the problem is that the kernelCandidate is neither a SourceRecord nor an object (what kind?) that has a getSource() method.
Cadiate -> Candidate
Do you expect all candidates to be of the same type? If so, I think it would be safer and cleaner to preprocess candidateInList based on the type of the first entry (e.g. convert it to a list of source records, regardless of what it started out as).
There was a problem hiding this comment.
Use the modern version of raise:
raise RuntimeError("Candidate something something")
There was a problem hiding this comment.
Depending on where the kernel candidates come from they are either a lsst.afw.table.SourceRecord or a lsst.meas.algorithms.algorithmsLib.PsfCandidateF.
That is a much better idea to check the type and convert the whole list; I'll move this to the calling task, ImagePsfMatchTask.makeCandidateList(), which already has some type checking in it.
yalsayyad
force-pushed
the
tickets/DM-3213
branch
4 times, most recently
from
6d62d22
to
83fb111
Compare
yalsayyad
force-pushed
the
tickets/DM-3213
branch
from
83fb111
to
2236247
Compare
dipoleMeasurment: Add SourceFlagChecker to __all__
diaCatalogSourceSelector: default flag slot names
DipoleMeasurementConfig: default slots.centroid
- 'ip_diffim_NaiveDipoleCentroid_pos'-->'ip_diffim_NaiveDipoleCentroid'
- '..._pos' is not an algorithm and does not work in slots.centroid
outside of unit tests. When running ip_diffim_NaiveDipoleCentroid in
a slot both unit tests and ImageDifferenceTask require
_x/_y fields be added to schema.
Existing type check was a no-op: type of the type and class were both <type 'type'>. Improve to convert the candidateList to a list of SourceRecords if possible. For example, if kernelCandidates recycled from the src dataset, the candidatelList is of type lsst.meas.algorithms.PsfCandidateF.
No need to log pexExcept.Expections and Expections separately anymore
yalsayyad
force-pushed
the
tickets/DM-3213
branch
from
2236247
to
dd403b3
Compare
No description provided.