DM-10804: Spatially-varying A&L decorrelation option #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey. Code looks good as far as I can tell but you need write docs for all of your new classes/functions and the classes/functions you edited. Unless I am mistaken we are required to use numpydoc style from now on. |
morriscb
requested changes
Jun 7, 2017
| self.decorrelateMapReduceConfig.reducerSubtask.reduceOperation = 'average' | ||
|
|
||
|
|
||
| class DecorrelateALKernelSpatialTask(pipeBase.Task): |
There was a problem hiding this comment.
I don't see the task documentation for doxygen; https://confluence.lsstcorp.org/display/DM/How+to+document+a+Task
| self.statsControl = afwMath.StatisticsControl() | ||
| self.statsControl.setNumSigmaClip(3.) | ||
| self.statsControl.setNumIter(3) | ||
| ignoreMaskPlanes = ("INTRP", "EDGE", "DETECTED", "SAT", "CR", "BAD", "NO_DATA", "DETECTED_NEGATIVE") |
morriscb
approved these changes
Jun 16, 2017
|
Assuming the docs and code run/pass CI the code is ready to merge. |
djreiss
force-pushed
the
tickets/DM-10804
branch
from
2056629
to
700212a
Compare
Add unit test for DecorrelateALKernelSpatialTask Remove redundant logging
djreiss
force-pushed
the
tickets/DM-10804
branch
from
700212a
to
9f41885
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.