Make coadd template warp type configurable #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `--config getTemplate.warpType=psfMatched` to get PSF-matched coadds as templates.
isullivan
approved these changes
Sep 22, 2017
| TODO: This nearly duplicates a method in CoaddBaseTask (DM-11985) | ||
| """ | ||
| warpType = self.config.warpType | ||
| suffix = "" if warpType == "direct" else warpType[0].upper() + warpType[1:] |
There was a problem hiding this comment.
This is probably the most efficient way of doing this, but using warpType .title() would be more clear.
There was a problem hiding this comment.
Would have been more clear, if it did what I wanted.
>>> 'psfMatched'.title()
'Psfmatched' :(
There was a problem hiding this comment.
Oops. Yes, I didn't realize that would un-capitalize letters in the rest of the word. Good catch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
--config getTemplate.warpType=psfMatchedto getPSF-matched coadds as templates.