DM-14204: Modernize python in ip_* packages #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-owen
force-pushed
the
tickets/DM-14204
branch
2 times, most recently
from
4880360
to
d083bcf
Compare
natelust
approved these changes
Apr 30, 2018
| import unittest | ||
|
|
||
| from builtins import range | ||
| from past.builtins import basestring |
There was a problem hiding this comment.
As you are doing more than future, you may consider changing the commit message to something about dropping py2 support and syntax, but it is just a suggestion
|
|
||
| This task has no debug variables | ||
|
|
||
| \section ip_diffim_imageDecorrelation_DecorrelateALKernelSpatialTask_Example Example of using DecorrelateALKernelSpatialTask | ||
| @section ip_diffim_imageDecorrelation_DecorrelateALKernelSpatialTask_Example Example of using DecorrelateALKernelSpatialTask # noqa E501 |
There was a problem hiding this comment.
Should there be two spaces before Example?
There was a problem hiding this comment.
It does not make any difference. However, in responding to this I see another error: the # noqa 501 is going to show up as part of the title so will fix that (in two files) by shortening the line and removing the # noqa. While I'm fixing that I'll make it one space in the files I fix.
Doxygen and pep8 don't get along very well.
r-owen
force-pushed
the
tickets/DM-14204
branch
from
d083bcf
to
ae53a1c
Compare
Remove use of future and __future__
r-owen
force-pushed
the
tickets/DM-14204
branch
from
ae53a1c
to
10ea640
Compare
I don't know how to fix or hide the ## E266 warnings for the `##` comment blocks.
r-owen
force-pushed
the
tickets/DM-14204
branch
from
d30ae36
to
49aad9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.