Skip to content

Commit

Permalink
Refine the unit tests
Browse files Browse the repository at this point in the history
  • Loading branch information
enourbakhsh committed Dec 14, 2023
1 parent 02234ff commit e8fb730
Show file tree
Hide file tree
Showing 2 changed files with 348 additions and 98 deletions.
5 changes: 2 additions & 3 deletions python/lsst/ip/isr/ampOffset.py
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,6 @@ def run(self, exposure):
print(
"All pixels masked: cannot calculate any amp offset corrections. All pedestals are being set"
)
breakpoint()
pedestals = np.zeros(len(amps))
else:
# Set up amp offset inputs.
Expand Down Expand Up @@ -486,8 +485,8 @@ def getInterfaceOffset(self, ampIdA, ampIdB, edgeA, edgeB):
interfaceOffset = 0
self.log.warning(
f"The fraction of unmasked pixels for amp interface {interfaceId} is below the threshold "
f"({self.config.ampEdgeMinFrac}) or the absolute offset value exceeds the limit "
f"({self.config.ampEdgeMaxOffset} ADU). Setting the interface offset to 0."
f"({ampEdgeGoodFrac:.2f} <? {self.config.ampEdgeMinFrac}) or the absolute offset value exceeds the limit "

Check failure on line 488 in python/lsst/ip/isr/ampOffset.py

View workflow job for this annotation

GitHub Actions / call-workflow / lint

E501

line too long (122 > 110 characters)
f"({np.abs(interfaceOffset):.2f} >? {self.config.ampEdgeMaxOffset} ADU). Setting the interface offset to 0."

Check failure on line 489 in python/lsst/ip/isr/ampOffset.py

View workflow job for this annotation

GitHub Actions / call-workflow / lint

E501

line too long (124 > 110 characters)
)
self.log.debug(
f"amp interface {interfaceId} : "
Expand Down

0 comments on commit e8fb730

Please sign in to comment.