Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-20287: Use '%' strings instead of "f" strings for log messages. #103

Merged
merged 1 commit into from
Jul 16, 2019
Merged

DM-20287: Use '%' strings instead of "f" strings for log messages. #103

merged 1 commit into from
Jul 16, 2019

Conversation

czwa
Copy link
Contributor

@czwa czwa commented Jun 28, 2019

No description provided.

@czwa czwa requested a review from PaulPrice June 28, 2019 17:00
PaulPrice
PaulPrice requested changes Jul 1, 2019
View reviewed changes
Copy link
Contributor

@PaulPrice PaulPrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, but I think you missed a subtlety in the use of the logger. We want the logger to do the stringification because it may not be necessary (if the logging level is set high).

python/lsst/ip/isr/isrTask.py Show resolved Hide resolved
python/lsst/ip/isr/isrTask.py Outdated Show resolved Hide resolved
python/lsst/ip/isr/isrTask.py Outdated Show resolved Hide resolved
PaulPrice
PaulPrice approved these changes Jul 10, 2019
View reviewed changes
Copy link
Contributor

@PaulPrice PaulPrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late response; I only just saw that this had been changed.

Looks good! One trivial suggestion.

python/lsst/ip/isr/isrTask.py Outdated Show resolved Hide resolved
@czwa czwa merged commit 4e3c610 into master Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timj timj timj left review comments

@jdswinbank jdswinbank jdswinbank left review comments

@PaulPrice PaulPrice PaulPrice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@czwa @timj @jdswinbank @PaulPrice