DM-5081: Mark amplifier edges SUSPECT if brighter-fatter is applied. #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdswinbank
reviewed
Jun 28, 2019
| @@ -2112,7 +2127,7 @@ def maskAndInterpolateDefects(self, exposure, defectBaseList): | |||
| defectBaseList : `List` of `Defects` | |||
|
|
|||
| """ | |||
| self.maskDefects(exposure, defectBaseList) | |||
| self.maskDefect(exposure, defectBaseList) | |||
There was a problem hiding this comment.
...how did this work before? Did this work before?
There was a problem hiding this comment.
I don't have a clear answer.
czwa
force-pushed
the
tickets/DM-5081
branch
2 times, most recently
from
241ab4b
to
dcdbd18
Compare
timj
reviewed
Jul 26, 2019
IsrTask.maskDefect() also masks edges if the IsrTaskConfig.numEdgeSuspect value is non-zero. This is somewhat unclear, as the edges aren't really defects. Splitting this masking to a new method makes the code clearer, and all cases where maskDefect is called now also call maskEdges.
The edges of amplifiers that have had the brighter-fatter correction applied may not have had the appropriate correction applied. To reflect this fact, ensure that the number of edge pixels matching the convolution boundary (1/2 the kernel size) are masked with the EDGE bit, using the maskEdges method. Docstring clarification.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The edges of amplifiers that have had the brighter-fatter correction
applied may not have had the appropriate correction applied. To
reflect this fact, ensure that the number of edge pixels masked is the
larger of IsrTask.config.numEdgeSuspect and the brighter-fatter kernel
size.