Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-18610: Add fields, limited mutability, and trim/assembly-state tracking to cameraGeom #112

Merged
merged 2 commits into from Nov 4, 2019
Merged

DM-18610: Add fields, limited mutability, and trim/assembly-state tracking to cameraGeom #112

merged 2 commits into from Nov 4, 2019

Conversation

czwa
Copy link
Contributor

@czwa czwa commented Sep 18, 2019

  • Update to support afw.cameraGeom changes.
  • Fix ReadoutCorner usage.

@czwa czwa requested a review from PaulPrice September 24, 2019 20:15
PaulPrice
PaulPrice approved these changes Sep 24, 2019
View reviewed changes
Copy link
Contributor

@PaulPrice PaulPrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few oversights that need to be cleaned up.
I suspect these two commits should be squashed together, as I didn't see a clear distinction between them.
Please add to the commit message a short summary of what the changes are that you're adapting to.

tests/test_crosstalk.py Outdated Show resolved Hide resolved
tests/test_empiricalVariance.py Outdated Show resolved Hide resolved
tests/test_isrFunctions.py Outdated Show resolved Hide resolved
tests/test_isrFunctions.py Outdated Show resolved Hide resolved
tests/test_isrTask.py Outdated Show resolved Hide resolved
tests/test_isrTask.py Outdated Show resolved Hide resolved
tests/test_isrTask.py Outdated Show resolved Hide resolved
python/lsst/ip/isr/isrTask.py Outdated Show resolved Hide resolved
@mfisherlevine
Copy link
Contributor

Obviously beyond the scope of this PR, but in seeing this fly by I just noticed that there is a countMaskedPixels() function defined here, which is unfortunate, as that is also a utility function in cp_pipe. And then I realised that the function is also defined identically in both test_isrTask.py and test_isrFunctions.py. I'm not quite sure where the best place for things like that is though. Thoughts?

@timj
Copy link
Member

timj commented Sep 25, 2019

Naively it sounds like a method on the mask.

@czwa
Update to support afw.cameraGeom changes.
a600df4 
Use Builder methods when changing amplifier/detector/camera
properties.  Use detector.getAmplifiers() method in place of removed
.getAmpInfoCatalog().  Use lsst.afw.cameraGeom.ReadoutCorner enum.
@czwa czwa merged commit ec7487a into master Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaulPrice PaulPrice PaulPrice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@czwa @mfisherlevine @timj @PaulPrice