DM-20574: Remove deprecated methods and options. #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonKrughoff
approved these changes
Nov 5, 2019
python/lsst/ip/isr/isrFunctions.py
Outdated
| @@ -926,55 +850,6 @@ def attachTransmissionCurve(exposure, opticsTransmission=None, filterTransmissio | |||
| return combined | |||
|
|
|||
|
|
|||
| @deprecated(reason="Camera geometry-based SkyWcs are now set when reading raws. To be removed after v19.", | |||
There was a problem hiding this comment.
This says after v19, but we haven't cut v19 yet. Is this just going to wait until that happens (it should be soon).
There was a problem hiding this comment.
It means that the message says "after v19" in the v19 release so that people know that v20 won't have the command.
There was a problem hiding this comment.
Now I understand. This one says "after v19" but all the others say "after v18". Only the "after v18" ones are meant to be deleted now. The v19 ones are to be deleted in a few weeks when v19 is out.
There was a problem hiding this comment.
Restored here, and across obs_ packages.
czwa
force-pushed
the
tickets/DM-20574
branch
2 times, most recently
from
9fb36b9
to
0dec367
Compare
timj
approved these changes
Nov 8, 2019
czwa
force-pushed
the
tickets/DM-20574
branch
from
0dec367
to
0fd607c
Compare
czwa
force-pushed
the
tickets/DM-20574
branch
from
0fd607c
to
48b2672
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the deprecated functions/configurations: