DM-22108: Fix gen3 handling of defects. #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
reviewed
Nov 5, 2019
czwa
force-pushed
the
tickets/DM-22108
branch
from
00e32c6
to
d37d52b
Compare
|
Jenkins noted that there is no |
timj
reviewed
Nov 5, 2019
python/lsst/ip/isr/isrTask.py
Outdated
| if self.config.doDefect is True: | ||
| if "defects" not in inputs: | ||
| inputs['defects'] = None | ||
| if inputs['defects'] is not None: |
There was a problem hiding this comment.
Are both if checks needed separately? Can't we combine?
if "defects" in inputs and inputs["defect"] is not None:saves us from doing an extra assignment?
plazas
approved these changes
Nov 5, 2019
There was a problem hiding this comment.
The changes look good. The only question I had is, if the user sets self.config.doDefects=True but there are no defect list, then inputs['defects'] = None, should it complain or raise or warn or say something like “you told me to do defects, but I can’t find any defects list”? Or is this something that happens later?. Chris has checked that indeed this is handled later along the way.
This should resolve KeyError exceptions when the inputs hash does not contain defects.
czwa
force-pushed
the
tickets/DM-22108
branch
from
d37d52b
to
285d8da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve KeyError exceptions when the inputs hash does not
contain defects.