DM-21739: Enable and test fringe/strayLight in gen3 #116
Conversation
czwa
force-pushed
the
tickets/DM-21739
branch
from
ce35358
to
1c70739
Compare
python/lsst/ip/isr/isrTask.py
Outdated
| # straylightRef = inputs['strayLightData'] | ||
| # diskUri = straylightRef.getUri() | ||
| # inputs['strayLightData'] = diskUri | ||
| print("Recieved straylightData: ", inputs['strayLightData']) |
There was a problem hiding this comment.
Probably remove this debug print and put back in the comments?
There was a problem hiding this comment.
I'm rewriting this, as butler now handles StrayLightData objects. This mitigates the need for the getUri, as inputs['strayLightData'] now contains the object itself.
python/lsst/ip/isr/fringe.py
Outdated
| fringe = assembler.assembleCcd(fringe) | ||
| fringeExp = assembler.assembleCcd(fringeExp) | ||
|
|
||
| seed = self.config.stats.rngSeedOffset + 12345678 |
There was a problem hiding this comment.
why this magic number, if no reason add a comment. If there is a reason, add a comment
There was a problem hiding this comment.
Updated to try to use the exposureId as in gen2 instead of a magic number.
python/lsst/ip/isr/isrTask.py
Outdated
| # straylightRef = inputs['strayLightData'] | ||
| # diskUri = straylightRef.getUri() | ||
| # inputs['strayLightData'] = diskUri | ||
| print("Recieved straylightData: ", inputs['strayLightData']) |
There was a problem hiding this comment.
I think you dont want to print here, but add it to inputs?
There was a problem hiding this comment.
As above, rewritten. inputs['strayLightData'] should get what it says from the butler, and if not, rely on the straylight task to raise if it can't handle things.
tests/test_fringes.py
Outdated
| self.assertFloatsAlmostEqual(medianAfter, 3002.233, atol=1e-4) | ||
| self.assertFloatsAlmostEqual(stdAfter, 3549.9375, atol=1e-4) | ||
| self.assertFloatsAlmostEqual(medianAfter, 3001.312, atol=1e-4) | ||
| self.assertFloatsAlmostEqual(stdAfter, 3549.949, atol=1e-4) |
There was a problem hiding this comment.
What did these values change?
There was a problem hiding this comment.
These values are related to how the fringe seed value is set. The tolerance likely should be smaller to more accurately represent the error in this measurement due to changes in seed, but I'm not going to worry about it on this ticket.
These seem to differ from those made by stand-alone repos.
czwa
force-pushed
the
tickets/DM-21739
branch
from
25d3be0
to
c9cfb45
Compare
No description provided.