Fix bitrot for using new style brighter-fatter kernels #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfisherlevine
force-pushed
the
tickets/DM-22659
branch
from
0ed9f9e
to
a0b22c0
Compare
mfisherlevine
force-pushed
the
tickets/DM-22659
branch
3 times, most recently
from
1de0e16
to
2d36927
Compare
mfisherlevine
force-pushed
the
tickets/DM-22659
branch
from
2d36927
to
fa3be3f
Compare
czwa
approved these changes
Dec 21, 2019
| elif brighterFatterKernel.detectorKernelFromAmpKernels: | ||
| brighterFatterKernel = brighterFatterKernel.detectorKernelFromAmpKernels[ccd.getId()] | ||
| else: | ||
| raise RuntimeError("Failed to extract kernel from new-style BF kernel.") | ||
| else: | ||
| # TODO DM-15631 for implementing this | ||
| raise NotImplementedError("Per-amplifier brighter-fatter correction not implemented") |
There was a problem hiding this comment.
Can you duplicate this logic into the gen3 runQuantum() method (line isrTask.py:827)? The kernel object should be supplied as inputs['bfKernel'], and can be overwritten in place by the appropriate detectorKernel (the linearizer gets and uses a detector as well). Adding the inputs['bfGains'] entry should ensure this works cleanly in that case.
There was a problem hiding this comment.
I was about to try, but I have no way of testing what I've done as I don't have any Gen3 repos (or even knowledge yet), and combined with no experience in such things, I think it's best left. I'll ticket, leave a TODO: and assign it to you. Sorry and thanks!
mfisherlevine
force-pushed
the
tickets/DM-22659
branch
from
fa3be3f
to
3822d18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unused config option for specifying files