DM-23083: Update large masks for BF convolution issues #123
Conversation
python/lsst/ip/isr/isrFunctions.py
Outdated
| fpSet = afwDetection.FootprintSet(fpSet, rGrow=growSaturatedFootprints, isotropic=False) | ||
| fpSet.setMask(mask, "SAT") | ||
| growMasks(mask, radius=growSaturatedFootprints, maskNameList=['SAT'], maskValue="SAT") | ||
| # thresh = afwDetection.Threshold(mask.getPlaneBitMask("SAT"), afwDetection.Threshold.BITMASK) |
There was a problem hiding this comment.
Leave the original inline comment, but remove the commented out code.
python/lsst/ip/isr/isrTask.py
Outdated
| @@ -2127,6 +2141,43 @@ def maskEdges(self, exposure, numEdgePixels=0, maskPlane="SUSPECT"): | |||
| maskBitMask | |||
| ) | |||
|
|
|||
| def maskGrowTophat(self, exposure, boxRadius=0, boxThreshold=0.25, maskPlane="BAD", maskLabel="BAD"): | |||
There was a problem hiding this comment.
Delete the definition of maskGrowTophat. It'll bitrot without a unit test or use anywhere
python/lsst/ip/isr/isrFunctions.py
Outdated
| Mask image to process. | ||
| radius : scalar | ||
| Amount to grow the mask. | ||
| maskNameList : `list` [`str`] |
There was a problem hiding this comment.
This isn't correct anymore since you no longer pass in a list here:
isrFunctions.growMasks(ccdExposure.getMask(),
radius=self.config.brighterFatterMaskGrowSize,
maskNameList=maskPlane,
maskValue=maskPlane)
You're passing in a single string. The current interface isn't bad, but worth thinking about whether growing a maskNameList with a single maskValue is the most reusable.
There was a problem hiding this comment.
growMasks uses the mask.getPlaneBitMask() method, which accepts vectors of strings or single strings, and returns the appropriate value. I've updated the docstring to note both str and list [str] are valid types.
python/lsst/ip/isr/isrFunctions.py
Outdated
| @@ -134,6 +134,27 @@ def makeThresholdMask(maskedImage, threshold, growFootprints=1, maskName='SAT'): | |||
| return measAlg.Defects.fromFootprintList(fpList) | |||
|
|
|||
|
|
|||
| def growMasks(mask, radius=0, maskNameList=['BAD'], maskValue="BAD"): | |||
| """Grow a mask by an amount and add to the BAD plane. | |||
There was a problem hiding this comment.
This docstring isn't correct after the behavior change. BAD is just your default value.
The brighter-fatter correction convolves pixel values in a way that isn't safe around masked regions (similar to the edge issue). To resolve this, allow masks to be grown by a fixed pixel radius to cover the pixels that are likely not corrected fully.
czwa
force-pushed
the
tickets/DM-23083
branch
from
5f17833
to
a51890c
Compare
Grow large masks after BF correction.
Large masks should be treated like edges in the mask plane. To do so,
convolve the important problem masks (those that are interpolated) by
a top-hat the size of the BF kernel, and add pixels to the mask if
they are calculated using a significant fraction of masked pixels.