DM-6147 #13
DM-6147 #13
Conversation
| @@ -619,7 +625,7 @@ def getIsrExposure(self, dataRef, datasetType, immediate=True): | |||
| return exp | |||
|
|
|||
| def saturationDetection(self, exposure, amp): | |||
| """!Detect saturated pixels and mask them using mask plane "SAT", in place | |||
| """!Detect saturated pixels and mask them using mask plane config.saturatedMaskName, in place | |||
There was a problem hiding this comment.
Thanks. I'm not convinced this should be a config param, but since it is, the old docs were wrong.
|
I feel like there should be a test that does both saturation and suspect detection, to help define how those two interact. Whether that should live in testSuspectMasking.py or some other file, I'm not sure, but I feel like it's an important integration test. It would call isrTask.run(), but maybe that suggests that the stuff inside the "for amp in ccd:" should live in a "do_amp()" method, which can then be tested separately? |
|
I would like to leave that for DM-6161 if at all possible. We don't presently have any unit test for IsrTask and we really need one. |
|
Ok: glad there's a ticket about it. Should I (or you?) add my note above about the possible refactor to that ticket? |
|
I don't understand about the refactoring. Perhaps you should add the note or explain it to me in person. |
No description provided.