DM-23623: Measure crosstalk coefficients for AuxTel chip and add for use #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfisherlevine
requested changes
Apr 2, 2020
python/lsst/ip/isr/crosstalk.py
Outdated
Comment on lines
170
to
172
| RuntimeError | ||
| Raised if crosstalkSources is not None and not a numpy | ||
| array or a dictionary. |
There was a problem hiding this comment.
Please combine these three lines with the explanation above, so that all the reasons for raising a RuntimeError are defined under the RuntimeError heading.
python/lsst/ip/isr/crosstalk.py
Outdated
| coeffs.append(tempList) | ||
| coeffs = np.array(coeffs) | ||
| else: | ||
| raise RuntimeError("crosstalkSources not of the correct type: `np.array` or `dict`") |
There was a problem hiding this comment.
This should be a TypeError I think, (and therefore noted separately in the Raises section in the docstring actually)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.