DM-23369: Remove lsst.ip.isr.addDistortionModel #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdswinbank
force-pushed
the
tickets/DM-23369
branch
from
91c5096
to
79f1302
Compare
parejkoj
approved these changes
Apr 27, 2020
| distortion model appropriate for this data. | ||
| The camera geometry for this exposure. Required if ``isGen3`` is | ||
| `True` and one or more of ``ccdExposure``, ``bias``, ``dark``, or | ||
| ``flat`` does not have an associated detector. |
There was a problem hiding this comment.
Oof, this is rather tortured logic for this parameter. It's not in scope for this ticket, but that sounds like it should be cleaned up somehow.
There was a problem hiding this comment.
It should probably be required in all cases to be explicit.
jdswinbank
force-pushed
the
tickets/DM-23369
branch
from
79f1302
to
9c41aa8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.