Tickets/dm 5462 #14
Merged
Tickets/dm 5462 #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-owen
force-pushed
the
tickets/DM-5462
branch
2 times, most recently
from
593ee52
to
3ba8393
Compare
| }}} // namespace lsst::ip::isr | ||
|
|
||
| #endif // !defined(LSST_IP_ISR_ISR_H) | ||
| #endif |
There was a problem hiding this comment.
Needs a newline at the end.
The main implementation header for ip_isr was in include/ip instead if include/ip/isr, so move it down a level and add a new include/ip/isr.h file that imports it (and, eventually, other header files).
Trac ticket 1121 is a report that it was sometimes necessary to have this in your .i includes, for no obvious reason: I tried taking it out and it works, so the problem appears to have been fixed.
applyLookupTable adds values from a lookup table to an image; it is designed for use as non-linearity correction.
Removed LookupTableMultiplicative and LookupTableReplace, neither of which was used, and neither of which did what was needed for non-linearity correction.
Add the following classes to correct non-linearity: - LinearizeBase abstract base class - LinearizeLookupTable linearize using a lookup table - LinearizeSquared linearize using corr = im + sqCoeff*im^2
Fixed flake8 warnings in the python code: - remove trailing whitespace - break long lines - remove unused imports - stop setting unused variables - break multi-line commands into a single line
testFringes had an undefined variable that was only exposed if "debug" was defined.
Add a new config field doLinearize (defaults to False because so few cameras support linerization). Unpersist and call the linearizer if doLinearize true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.