Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-23983: Cannot apply crosstalk in Gen 3 DECam processing #140

Merged
merged 10 commits into from
Jun 11, 2020
Merged

DM-23983: Cannot apply crosstalk in Gen 3 DECam processing #140

merged 10 commits into from
Jun 11, 2020

Commits on Jun 1, 2020

  1. Add CrosstalkCalib subclass of IsrCalib. 

    This new implementation supports both intra-chip crosstalk via the
CrosstalkCalib.coeffs attribute and inter-chip crosstalk via the
CrosstalkCalib.interChip dictionary.  Generic methods have been moved
into the calibration, and the CrosstalkTask.run updated to work with
the new calibration and to apply the inter-chip crosstalk if it
exists.
    @czwa
    czwa committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    a54e212 View commit details
    Browse the repository at this point in the history

  2. Fix astropy handling of multi-extension fits.

    @czwa
    czwa committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    5e7e9c1 View commit details
    Browse the repository at this point in the history

  3. Fix consequences of new CrosstalkCalib. 

    Simplify IsrMock as the calibration handles amplifier flips.

Update measureCrosstalk to persist output as CrosstalkCalib, and fix
broken unit tests.
    @czwa
    czwa committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    0b27906 View commit details
    Browse the repository at this point in the history

  4. Add gen3 handler for crosstalkSources. 

    Update output type to a generic Exposure needed for running pipelines
that split ISR processing into separate task calls (such as DECam ISR
with Crosstalk).
    @czwa
    czwa committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    a95332d View commit details
    Browse the repository at this point in the history

  5. Remove 'visit' from crosstalkSources.

    @czwa
    czwa committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    31ec924 View commit details
    Browse the repository at this point in the history

  6. Disable automatic date setting.

    @czwa
    czwa committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    744d342 View commit details
    Browse the repository at this point in the history

  7. Fix gen3 crosstalk when supplied via config.

    @czwa
    czwa committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    ced29bd View commit details
    Browse the repository at this point in the history

  8. Fix mistakenly dropped astropy read issue.

    @czwa
    czwa committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    3f2f06f View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2020

  1. Clarify docstrings.

    @czwa
    czwa committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    8deb4f6 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2020

  1. Add comments on crosstalkSources issue. 

    DM-25348 will resolve this problem.
    @czwa
    czwa committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    5b9bb1a View commit details
    Browse the repository at this point in the history