DM-24760: Migrate measureCrosstalk.py to cp_pipe #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czwa
force-pushed
the
tickets/DM-24760
branch
4 times, most recently
from
02a98d1
to
ba8c59f
Compare
These elements were being silently dropped even when the input calibration populated the entries. To ensure this isn't the case, initialize these fields as matching the shape of the coefficient table when they do not exist. For simplicity, the __init__ method now allows the calibration to be initialized to the correct size if the nAmp parameter is passed.
DMTN-148 listed header/metadata keywords that would be required. This attempts to ensure that the base class handles them consistently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove measureCrosstalk.py, and update CrosstalkCalib to retain all measured parameters.