Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM- 26629: switch to calibration collections instead of the calibration_label dimension #156

Merged
merged 1 commit into from
Sep 26, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
43 changes: 29 additions & 14 deletions python/lsst/ip/isr/isrTask.py
Original file line number Diff line number Diff line change
Expand Up @@ -109,14 +109,16 @@ class IsrTaskConnections(pipeBase.PipelineTaskConnections,
name="camera",
storageClass="Camera",
doc="Input camera to construct complete exposures.",
dimensions=["instrument", "calibration_label"],
dimensions=["instrument"],
isCalibration=True,
)

crosstalk = cT.PrerequisiteInput(
name="crosstalk",
doc="Input crosstalk object",
storageClass="CrosstalkCalib",
dimensions=["instrument", "calibration_label", "detector"],
dimensions=["instrument", "detector"],
isCalibration=True,
)
# TODO: DM-25348. This does not work yet to correctly load
# possible crosstalk sources.
Expand All @@ -133,79 +135,92 @@ class IsrTaskConnections(pipeBase.PipelineTaskConnections,
name="bias",
doc="Input bias calibration.",
storageClass="ExposureF",
dimensions=["instrument", "calibration_label", "detector"],
dimensions=["instrument", "detector"],
isCalibration=True,
)
dark = cT.PrerequisiteInput(
name='dark',
doc="Input dark calibration.",
storageClass="ExposureF",
dimensions=["instrument", "calibration_label", "detector"],
dimensions=["instrument", "detector"],
isCalibration=True,
)
flat = cT.PrerequisiteInput(
name="flat",
doc="Input flat calibration.",
storageClass="ExposureF",
dimensions=["instrument", "physical_filter", "calibration_label", "detector"],
dimensions=["instrument", "physical_filter", "detector"],
isCalibration=True,
)
fringes = cT.PrerequisiteInput(
name="fringe",
doc="Input fringe calibration.",
storageClass="ExposureF",
dimensions=["instrument", "physical_filter", "calibration_label", "detector"],
dimensions=["instrument", "physical_filter", "detector"],
isCalibration=True,
)
strayLightData = cT.PrerequisiteInput(
name='yBackground',
doc="Input stray light calibration.",
storageClass="StrayLightData",
dimensions=["instrument", "physical_filter", "calibration_label", "detector"],
dimensions=["instrument", "physical_filter", "detector"],
isCalibration=True,
)
bfKernel = cT.PrerequisiteInput(
name='bfKernel',
doc="Input brighter-fatter kernel.",
storageClass="NumpyArray",
dimensions=["instrument", "calibration_label"],
dimensions=["instrument"],
isCalibration=True,
)
newBFKernel = cT.PrerequisiteInput(
name='brighterFatterKernel',
doc="Newer complete kernel + gain solutions.",
storageClass="BrighterFatterKernel",
dimensions=["instrument", "calibration_label", "detector"],
dimensions=["instrument", "detector"],
isCalibration=True,
)
defects = cT.PrerequisiteInput(
name='defects',
doc="Input defect tables.",
storageClass="Defects",
dimensions=["instrument", "calibration_label", "detector"],
dimensions=["instrument", "detector"],
isCalibration=True,
)
opticsTransmission = cT.PrerequisiteInput(
name="transmission_optics",
storageClass="TransmissionCurve",
doc="Transmission curve due to the optics.",
dimensions=["instrument", "calibration_label"],
dimensions=["instrument"],
isCalibration=True,
)
filterTransmission = cT.PrerequisiteInput(
name="transmission_filter",
storageClass="TransmissionCurve",
doc="Transmission curve due to the filter.",
dimensions=["instrument", "physical_filter", "calibration_label"],
dimensions=["instrument", "physical_filter"],
isCalibration=True,
)
sensorTransmission = cT.PrerequisiteInput(
name="transmission_sensor",
storageClass="TransmissionCurve",
doc="Transmission curve due to the sensor.",
dimensions=["instrument", "calibration_label", "detector"],
dimensions=["instrument", "detector"],
isCalibration=True,
)
atmosphereTransmission = cT.PrerequisiteInput(
name="transmission_atmosphere",
storageClass="TransmissionCurve",
doc="Transmission curve due to the atmosphere.",
dimensions=["instrument"],
isCalibration=True,
)
illumMaskedImage = cT.PrerequisiteInput(
name="illum",
doc="Input illumination correction.",
storageClass="MaskedImageF",
dimensions=["instrument", "physical_filter", "calibration_label", "detector"],
dimensions=["instrument", "physical_filter", "detector"],
isCalibration=True,
)

outputExposure = cT.Output(
Expand Down