DM-27157: constructDark.py fails on LSSTCam with 'Image contains no Pixels' #160
Conversation
| @@ -342,7 +346,10 @@ def collapseArrayMedian(self, maskedArray): | |||
| fitType = afwMath.stringToStatisticsProperty('MEDIAN') | |||
| for row in integerMI: | |||
| newRow = row.compressed() | |||
There was a problem hiding this comment.
What is this compressed returning? How could it be empty? (which is what you check for in the next conditional)
There was a problem hiding this comment.
compressed returns all values of the maskedArray that are not masked. The case where len(newRow) == 0 is the case where all elements of this row's overscan are masked, and so the newRow is empty.
| @@ -523,6 +534,13 @@ def debugView(self, image, model): | |||
| axes.plot(indices, plotModel, 'r-') | |||
| plot.xlabel("centered/scaled position along overscan region") | |||
| plot.ylabel("pixel value/fit value") | |||
| if amp: | |||
There was a problem hiding this comment.
So, it's the {{amp}} only used to get information for the string in the title? (just confirming)
There was a problem hiding this comment.
Yes, this is code I pulled from DM-26281 before marking that invalid. Debugging overscan quickly becomes impossible without information about which amp you're looking at, which wasn't available before. Passing the optional amp gives information to make the title informative.
czwa
changed the title
This issue is a result of an overscan bug when
MEDIAN_BY_ROWis active and an overscan row is completely masked. In addition, the DM-26281 overscan debug rework is added here, as it was necessary to diagnose the issue.