Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-26484: Run read noise eotest task at NCSA #170

Merged
merged 2 commits into from
Jan 27, 2021
Merged

DM-26484: Run read noise eotest task at NCSA #170

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8bdf137
Report stats after overscan correction
plazas Jan 26, 2021
72c53cc
Rename overscan statistics
plazas Jan 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 12 additions & 0 deletions python/lsst/ip/isr/isrTask.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1382,6 +1382,18 @@ def run(self, ccdExposure, camera=None, bias=None, linearizer=None,
self.metadata.set(f"ISR OSCAN {amp.getName()} STDEV", qaStdev)
self.log.debug(" Overscan stats for amplifer %s: %f +/- %f",
amp.getName(), qaMedian, qaStdev)

# Residuals after overscan correction
qaStatsAfter = afwMath.makeStatistics(overscanResults.overscanImage,
afwMath.MEDIAN | afwMath.STDEVCLIP)
qaMedianAfter = qaStatsAfter.getValue(afwMath.MEDIAN)
qaStdevAfter = qaStatsAfter.getValue(afwMath.STDEVCLIP)

self.metadata.set(f"ISR OSCAN {amp.getName()} MEDIAN AFTER CORRECTION", qaMedianAfter)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change these to {{RESIDUAL MEDIAN}} and {{RESIDUAL STDEV}}? I think that might be easier to understand. Changing the ones above to {{FIT MEDIAN}} and {{FIT STDEV}} might help as well.

self.metadata.set(f"ISR OSCAN {amp.getName()} STDEV AFTTER CORRECTION", qaStdevAfter)
self.log.debug(" Overscan stats for amplifer %s after correction: %f +/- %f",
amp.getName(), qaMedianAfter, qaStdevAfter)

ccdExposure.getMetadata().set('OVERSCAN', "Overscan corrected")
else:
if badAmp:
Expand Down