DM-28093: Change isrTask (and relevant configs) to use physicalLabel #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parejkoj
reviewed
Mar 5, 2021
python/lsst/ip/isr/isrFunctions.py
Outdated
| return True | ||
| elif thisFilter.bandLabel in filterList: | ||
| if log: | ||
| log.warn("Physical filter (%s) should be used instead of band %s (%s)", |
There was a problem hiding this comment.
I feel like some kind of information is missing from this warning. Maybe something about the exposure that would allow the user to track down the problem? Or is this a warning about the filterList itself?
There was a problem hiding this comment.
It's a warning about the filterList. This ticket is migrating everything to use physicalLabel, but if someone changes the config file (or adds a new camera), I want there to be a warning that they should not use band.
There was a problem hiding this comment.
Please make that more clear in the log message: as it stands, it's not obvious.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ticket also provides a
checkFilterfunction, to reduce code duplication between fringe, straylight, etc filter checks against config parameters.