Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-7233: Pytest updates #18

Merged
merged 18 commits into from Aug 16, 2016
Merged

DM-7233: Pytest updates #18

merged 18 commits into from Aug 16, 2016

Conversation

timj
Copy link
Member

@timj timj commented Aug 15, 2016

No description provided.


def testSaturation(self):
saturation = 1000

bbox = afwGeom.Box2I(afwGeom.Point2I(0, 0), afwGeom.Point2I(19, 19))
maskedImage = afwImage.MaskedImageF(bbox)
maskedImage.set(100, 0x0, 1)
exposure = afwImage.ExposureF(maskedImage, None)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this here? Was it supposed to be tested?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the code using exposure was removed in commit dd64d97

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line (and the other removed one) was flagged as unused. @timj found the related commit.

@parejkoj parejkoj merged commit 164de64 into master Aug 16, 2016
@ktlim ktlim deleted the tickets/DM-7233 branch August 25, 2018 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants