DM-30738: Backport gen3 imSim BF-kernels for gen2 #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czwa
commented
Jun 15, 2021
| @@ -1147,15 +1147,15 @@ def readIsrData(self, dataRef, rawExposure): | |||
| except NoResults: | |||
| try: # Fall back to the old-style numpy-ndarray style kernel if necessary. | |||
| brighterFatterKernel = dataRef.get("bfKernel") | |||
| self.log.info("Old style brighter-fatter kernel (np.array) loaded") | |||
| self.log.info("Old style brighter-fatter kernel (bfKernel) loaded") | |||
| except NoResults: | |||
| brighterFatterKernel = None | |||
| if brighterFatterKernel is not None and not isinstance(brighterFatterKernel, numpy.ndarray): | |||
There was a problem hiding this comment.
All of the changes (except for the log message above) is protected by this if check. This means if we received a numpy array (which is the case for HSC), then this section is skipped. All of the other changes to support new brighter-fatter kernels has been done in gen3, which uses the runQuantum method to check and restructure calibrations. When we switch fully to gen3, this method will be removed, as it's only called in gen2.
There was a problem hiding this comment.
Ah, that's what I was missing...thanks for the explanation!
laurenam
approved these changes
Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix gen2 handling of detector level BF kernels.