Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-31489: Update StrayLightData to use FitsGenericFormatter with a deferred data set #192

Merged
merged 2 commits into from
Aug 26, 2021
Merged

DM-31489: Update StrayLightData to use FitsGenericFormatter with a deferred data set #192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
34b69b6
Make StrayLightData inherit from IsrCalib.
czwa Aug 23, 2021
7817676
Defer load of straylight data.
czwa Aug 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions python/lsst/ip/isr/isrTask.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,7 @@ class IsrTaskConnections(pipeBase.PipelineTaskConnections,
doc="Input stray light calibration.",
storageClass="StrayLightData",
dimensions=["instrument", "physical_filter", "detector"],
deferLoad=True,
isCalibration=True,
minimum=0, # only needed for some bands, even when enabled
)
Expand Down
5 changes: 3 additions & 2 deletions python/lsst/ip/isr/straylight.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,14 @@
#
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <https://www.gnu.org/licenses/>.
from abc import ABC, abstractmethod
from abc import abstractmethod
from typing import Optional

from lsst.pex.config import Config, Field, ListField
from lsst.pipe.base import Task
from lsst.geom import Angle
from .isrFunctions import checkFilter
from .calibType import IsrCalib


class StrayLightConfig(Config):
Expand Down Expand Up @@ -118,7 +119,7 @@ def checkFilter(self, exposure):
return checkFilter(exposure, self.config.filters, log=self.log)


class StrayLightData(ABC):
class StrayLightData(IsrCalib):
"""An abstract base class for rotator-dependent stray light information.
"""

Expand Down