DM-30648: Add photodiode calibration class #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
python/lsst/ip/isr/photodiode.py
Outdated
Comment on lines
253
to
264
| (q25, q50, q75) = np.nanpercentile(np.log10(self.currentSamples[good]), [25, 50, 75]) | ||
|
|
||
| good = np.where(np.abs(np.log10(self.currentSamples[good]) - q50) < 3.0 * 0.74 * (q75 - q25)) | ||
|
|
||
| current = self.currentSamples[good] | ||
| time = self.timeSamples[good] |
There was a problem hiding this comment.
It's late and I haven't made a toy to test, but I'm uneasy about how robust this is. Let me play with this on Monday...
There was a problem hiding this comment.
I just remembered about this toy I was going to make. I just tried, and let's just say I need a :rubber-duck:, so please don't merge until I resolve my internal squabbling at least!
czwa
force-pushed
the
tickets/DM-30648
branch
from
5d9246d
to
39c664a
Compare
czwa
commented
Oct 21, 2021
czwa
force-pushed
the
tickets/DM-30648
branch
from
39c664a
to
c63b2bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add photodiode calibration class.