Tickets/dm 98 #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A large chunk of code used once upon a time to report SDQA values is removed. There must be a better mechanism for doing this now.
In places docstrings were out of date. In others the docstrings were not in standard format. This commit fixes up the docstrings.
|
This looks good, though I had one complaint about your parameter formatting (please don't use colons). I assume ran this through buildbot; that would make sure the code you removed is not being used. Regarding the repair task in pipe_tasks: I see that it uses meas_algorithms, and I'm guessing you felt that was not something you wanted ip_isr to depend on? |
Apparently Doxygen doesn't like colons, so I removed them. I also fixed a typo afw.algorithms -> meas.algorithms.
|
Running forced build now. I'll merge when that comes back successful. |
There was a unit test for the Sdqa code removed as part of this ticket. This commit removes that unit test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.