Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-29326: Fix logic of the doVignette option in isrTask #203

Merged
merged 5 commits into from
Dec 1, 2021
Merged

DM-29326: Fix logic of the doVignette option in isrTask #203

merged 5 commits into from
Dec 1, 2021

Commits on Nov 29, 2021

  1. Add a check for an empty filterList in checkFilter 

    There's no point in continuing if the filter list is empty.
    @laurenam @czwa
    laurenam authored and czwa committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    fffefaa View commit details
    Browse the repository at this point in the history

  2. Update vignette code. 

     - Fix docstrings.
 - Make a missing polygon do no masking instead of full masking.
 - Update logging method.
    @czwa
    czwa committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    4564cf6 View commit details
    Browse the repository at this point in the history

  3. Re add doWriteVignettePolygon config option. 

    This is now ignored and deprecated, so it will warn.  This should help
track down any existing cases where it's used.
    @czwa
    czwa committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    ef87fde View commit details
    Browse the repository at this point in the history

  4. Update vignette tests.

    @czwa
    czwa committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    89d45b3 View commit details
    Browse the repository at this point in the history

  5. Clarify docstrings.

    @czwa
    czwa committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    7774b6e View commit details
    Browse the repository at this point in the history