Update for exposure time and date not in Calib #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulPrice
approved these changes
Sep 28, 2016
| outCalib.setExptime(inCalib.getExptime()) | ||
| outCalib.setMidTime(inCalib.getMidTime()) | ||
|
|
||
| # note: Calib is not copied, presumably because it is assumed uknown in raw data |
| @@ -528,7 +528,8 @@ def run(self, ccdExposure, bias=None, linearizer=None, dark=None, flat=None, def | |||
| if self.config.doFringe and self.config.fringeAfterFlat: | |||
| self.fringe.run(ccdExposure, **fringes.getDict()) | |||
|
|
|||
| ccdExposure.getCalib().setFluxMag0(self.config.fluxMag0T1 * ccdExposure.getCalib().getExptime()) | |||
| exposureTime = ccdExposure.getInfo().getVisitInfo().getExposureTime() | |||
| ccdExposure.getCalib().setFluxMag0(self.config.fluxMag0T1 * exposureTime) | |||
|
Thank you for the error reports. I will fix and rebase. |
r-owen
force-pushed
the
tickets/DM-5503
branch
2 times, most recently
from
ef679eb
to
ebad5bc
Compare
|
Fixed and rebased |
Update all code that used exposure time or date in Calib, switching to VisitInfo instead.
r-owen
force-pushed
the
tickets/DM-5503
branch
from
ebad5bc
to
73962dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update all code that used exposure time or date in Calib,
switching to VisitInfo instead.