DM-35594: Fully masked amplifiers can trigger read failures for PTC #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plazas
approved these changes
Jul 18, 2022
There was a problem hiding this comment.
It so happens that I also caught this bug while working on DM-35316 (with the same solution, it seems), which is currently looking for reviewers. I will approve this request, and once it is merged, I will rebase and fix potential conflicts in DM-35316. I think it is cleaner to have this ticket fixing this, separately from DM-35316, which deals with other things.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check array length before attempting to access entry -1.